fix: resume iterator on EOS internal error#122
Conversation
hengfengli
left a comment
There was a problem hiding this comment.
I think we need to add retry for "Received unexpected EOS on DATA frame from server" error message as well.
|
@larkee thanks for the fix, I will test it out with a long running PDML to make sure everything we need is in place! |
tseaver
left a comment
There was a problem hiding this comment.
This change really needs unit test coverage: I'm not sure why the Kokoro build is passing without it.
|
@larkee Quick update, the PDML long running task finished successfully in production testing. Thanks for fixing this! |
Co-authored-by: Tres Seaver <tseaver@palladion.com>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
The unit test coverage is back to 100% for all files touched by this change.
Fixes #120
This fixes the same issue as googleapis/java-spanner#360.
A similar issue was encountered by
bigquery-storageand was fixed in googleapis/google-cloud-python#9994.