Skip to content

feat(spanner): exporting transaction._rolled_back as transaction.rolled_back #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larkee merged 2 commits into from
Feb 18, 2020
Merged

feat(spanner): exporting transaction._rolled_back as transaction.rolled_back #16

larkee merged 2 commits into from
Feb 18, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Feb 12, 2020

Fixes #13

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2020
@HemangChothani
Copy link
Contributor Author

HemangChothani commented Feb 12, 2020

Just another alternative, the changes could be confined to the Transaction class:

@property
def rolled_back(self):
    return self._rolled_back

@rolled_back.setter
def rolled_back(self, value):
    self._rolled_back = value

crwilcox
crwilcox reviewed Feb 18, 2020
View reviewed changes
Copy link
Contributor

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. Will leave it to @larkee to approve.

larkee
larkee approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this! :)

@larkee larkee merged commit 974ee92 into googleapis:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larkee larkee larkee approved these changes

+1 more reviewer

@crwilcox crwilcox crwilcox left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

spanner: consider exporting Transaction._rolled_back as Transaction.rolled_back

4 participants

@HemangChothani @crwilcox @larkee @googlebot