feat(db_api): support JSON data type#627
Merged
skuruppu merged 13 commits intogoogleapis:mainfrom Nov 22, 2021
Merged
Conversation
larkee
approved these changes
Oct 21, 2021
Contributor
|
@IlyaFaer There are system test and sample failures relating to JSON comparisons because the assertions are expecting a JSON string but are getting a Python dict. This can be fixed by overriding the |
Contributor
|
@IlyaFaer There are lint errors and the sample assertions are still failing. |
Contributor
Author
|
@larkee, oh, looks like some samples requires some work. Working on it... |
Contributor
Author
|
@larkee, this one seems to be okay for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.