fix: Django and SQLAlchemy APIs are failing to use rowcount#654
Merged
vi3k6i5 merged 3 commits intogoogleapis:mainfrom Jan 6, 2022
Merged
fix: Django and SQLAlchemy APIs are failing to use rowcount#654vi3k6i5 merged 3 commits intogoogleapis:mainfrom
vi3k6i5 merged 3 commits intogoogleapis:mainfrom
Conversation
vi3k6i5
approved these changes
Jan 5, 2022
Contributor
vi3k6i5
left a comment
There was a problem hiding this comment.
LGTM, this will fix a lot of open issues in django and SQLAlchemy.
vi3k6i5
added a commit
to vi3k6i5/python-spanner
that referenced
this pull request
Mar 29, 2022
…is#654) * fix: Django and SQLAlchemy APIs are failing to use rowcount * lint fix Co-authored-by: Vikash Singh <3116482+vi3k6i5@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards:
googleapis/python-spanner-sqlalchemy#179
googleapis/python-spanner-django#740