Skip to content

feat: add helper for bucket bound hostname URLs #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 15 commits into from
May 28, 2020
Merged

feat: add helper for bucket bound hostname URLs #137

gcf-merge-on-green merged 15 commits into from
May 28, 2020

Conversation

@IlyaFaer
Copy link

@IlyaFaer IlyaFaer commented May 7, 2020

Closes #121

@IlyaFaer IlyaFaer added api: storage Issues related to the googleapis/python-storage API. type: cleanup An internal cleanup or hygiene concern. labels May 7, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2020
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2020
IlyaFaer
IlyaFaer commented May 7, 2020
View reviewed changes
@IlyaFaer IlyaFaer requested review from andrewsg, crwilcox and frankyn May 7, 2020 12:27
@IlyaFaer IlyaFaer marked this pull request as ready for review May 7, 2020 12:27
frankyn
frankyn suggested changes May 13, 2020
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this change @IlyaFaer, left a question.

frankyn and others added 9 commits May 14, 2020 13:43
frankyn
frankyn suggested changes May 22, 2020
View reviewed changes
@frankyn frankyn added the automerge Merge the pull request once unit tests and other checks pass. label May 27, 2020
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented May 27, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented May 27, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented May 28, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit b26f9fa into googleapis:master May 28, 2020
@IlyaFaer IlyaFaer deleted the bucker_bound_hostname_helper branch May 28, 2020 07:30
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@cojenco
feat: add helper for bucket bound hostname URLs (googleapis#137)
53e826d 
Closes googleapis#121
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@cojenco
feat: add helper for bucket bound hostname URLs (googleapis#137)
aeb2fa0 
Closes googleapis#121
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsg andrewsg Awaiting requested review from andrewsg

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move bucket_bound_hostname code into helper

4 participants

@IlyaFaer @frankyn @googlebot @yoshi-kokoro