fix: from_string method of blob and bucket class #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
suggested changes
Oct 8, 2020
Contributor
tseaver
left a comment
There was a problem hiding this comment.
Rather than changing the signature of Blob.from_string, the fix should be to change Blob._do_multipart_upload (and likewise Blob._initiate_resumable_upload) to use the passed-in client. The caller (Blob._do_upload) should likewise call self._require_client to use its own _client attribute as a fallback for when no explicit client is passed in.
tseaver
suggested changes
Oct 9, 2020
Contributor
Author
|
@tseaver PTAL! |
tseaver
approved these changes
Nov 11, 2020
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #286