docs: remove and replace deprecated function download_as_string() #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@richardevs Thanks for the patch! Next time, you can edit the PR title to fix the CC check, or do a |
tseaver
approved these changes
Jul 15, 2021
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…ogleapis#508) Remove deprecated function download_as_string(), replace with download_as_bytes(). [1] [1] https://github.com/googleapis/python-storage/blob/master/google/cloud/storage/blob.py#L138 Fixes googleapis#504 🦕
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…ogleapis#508) Remove deprecated function download_as_string(), replace with download_as_bytes(). [1] [1] https://github.com/googleapis/python-storage/blob/master/google/cloud/storage/blob.py#L138 Fixes googleapis#504 🦕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated function download_as_string(), replace with download_as_bytes(). [1]
[1] https://github.com/googleapis/python-storage/blob/master/google/cloud/storage/blob.py#L138
Fixes #504 🦕