Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Mar 25, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #36 🦕

@busunkim96 busunkim96 requested a review from a team as a code owner March 25, 2021 19:50
@product-auto-label product-auto-label bot added the api: websecurityscanner Issues related to the googleapis/python-websecurityscanner API. label Mar 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2021
@busunkim96 busunkim96 requested a review from parthea March 25, 2021 19:51
@busunkim96
Copy link
Contributor Author

(Please ignore the samples tests, I'm doing some other testing with those configs but there are no samples in this repo right now: https://github.com/googleapis/python-websecurityscanner/tree/master/samples)

@busunkim96 busunkim96 merged commit 8993d41 into master Mar 30, 2021
@busunkim96 busunkim96 deleted the add-v1 branch March 30, 2021 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: websecurityscanner Issues related to the googleapis/python-websecurityscanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add v1

2 participants