Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Add BPDR for static site generator criteria #304

Merged
merged 7 commits into from
Mar 30, 2022
Merged

Add BPDR for static site generator criteria #304

merged 7 commits into from
Mar 30, 2022

Conversation

echappen
Copy link
Collaborator

@echappen echappen commented Mar 21, 2022 •
edited
Loading

Creating this BPDR to continue discussion on the topic of alternative static site generators to Jekyll. The goal here is to agree on criteria, not on which alternative we should use (that'll come later). Areas needing more info are marked with TK. Comments welcome!

@echappen echappen changed the title Add ADR for static site generator criteria Add BPDR for static site generator criteria Mar 21, 2022
@github-actions
Copy link

Pa11y testing results 
> [email protected] pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 43 URLs:
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/apis/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215
    this.emit('error', new Error('Page crashed!'));
                       ^

Error: Page crashed!
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:24)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    at CDPSession.emit (node:events:520:28)
    at CDPSession._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:200:12)
    at Connection._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:112:17)
    at WebSocket.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
    at WebSocket.onMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/event-target.js:120:16)
    at WebSocket.emit (node:events:520:28)
    at Receiver.receiverOnMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/websocket.js:789:20)
    at Receiver.emit (node:events:520:28)
Emitted 'error' event on Page instance at:
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:10)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    [... lines matching original stack trace ...]
    at Receiver.emit (node:events:520:28)

@github-actions
Copy link

Pa11y testing results 
> [email protected] pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 43 URLs:
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/apis/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/on-call/ - 2 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/security/cloud-services/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
 > http://localhost:4000/security/ - 0 errors
 > http://localhost:4000/security/content-security-policy/ - 0 errors
 > http://localhost:4000/security/dependency-remediation/ - 0 errors
 > http://localhost:4000/security/output-encoding/ - 0 errors
 > http://localhost:4000/security/incident-response-drills/ - 0 errors
 > http://localhost:4000/sharepoint/ - 0 errors
 > http://localhost:4000/web-architecture/ - 0 errors
 > http://localhost:4000/workflow/ - 0 errors

Errors in http://localhost:4000/on-call/:

 • ARIA role must be appropriate for the element
   (https://dequeuniversity.com/rules/axe/3.5/aria-allowed-role?application=axeAPI)

   (#fnref:1)

   <sup id="fnref:1" role="doc-noteref"><a href="#fn:1" class="footnote...</sup>

 • ARIA role must be appropriate for the element
   (https://dequeuniversity.com/rules/axe/3.5/aria-allowed-role?application=axeAPI)

   (#fnref:2)

   <sup id="fnref:2" role="doc-noteref"><a href="#fn:2" class="footnote...</sup>

✘ 42/43 URLs passed

@github-actions
Copy link

Pa11y testing results 
> [email protected] pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 43 URLs:
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/apis/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/on-call/ - 2 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
 > http://localhost:4000/security/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/security/cloud-services/ - 0 errors
/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215
    this.emit('error', new Error('Page crashed!'));
                       ^

Error: Page crashed!
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:24)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    at CDPSession.emit (node:events:520:28)
    at CDPSession._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:200:12)
    at Connection._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:112:17)
    at WebSocket.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
    at WebSocket.onMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/event-target.js:120:16)
    at WebSocket.emit (node:events:520:28)
    at Receiver.receiverOnMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/websocket.js:789:20)
    at Receiver.emit (node:events:520:28)
Emitted 'error' event on Page instance at:
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:10)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    [... lines matching original stack trace ...]
    at Receiver.emit (node:events:520:28)

@github-actions
Copy link

Pa11y testing results 
> [email protected] pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 43 URLs:
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/apis/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/on-call/ - 2 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/security/ - 0 errors
 > http://localhost:4000/security/cloud-services/ - 0 errors
 > http://localhost:4000/security/dependency-remediation/ - 0 errors
 > http://localhost:4000/security/content-security-policy/ - 0 errors
 > http://localhost:4000/security/output-encoding/ - 0 errors
 > http://localhost:4000/security/incident-response-drills/ - 0 errors
 > http://localhost:4000/sharepoint/ - 0 errors
 > http://localhost:4000/workflow/ - 0 errors
 > http://localhost:4000/web-architecture/ - 0 errors

Errors in http://localhost:4000/on-call/:

 • ARIA role must be appropriate for the element
   (https://dequeuniversity.com/rules/axe/3.5/aria-allowed-role?application=axeAPI)

   (#fnref:1)

   <sup id="fnref:1" role="doc-noteref"><a href="#fn:1" class="footnote...</sup>

 • ARIA role must be appropriate for the element
   (https://dequeuniversity.com/rules/axe/3.5/aria-allowed-role?application=axeAPI)

   (#fnref:2)

   <sup id="fnref:2" role="doc-noteref"><a href="#fn:2" class="footnote...</sup>

✘ 42/43 URLs passed

@github-actions
Copy link

Pa11y testing results 
> [email protected] pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 43 URLs:
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/apis/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/on-call/ - 2 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
 > http://localhost:4000/security/ - 0 errors
 > http://localhost:4000/security/cloud-services/ - 0 errors
 > http://localhost:4000/security/content-security-policy/ - 0 errors
 > http://localhost:4000/security/dependency-remediation/ - 0 errors
 > http://localhost:4000/security/output-encoding/ - 0 errors
 > http://localhost:4000/security/incident-response-drills/ - 0 errors
 > http://localhost:4000/sharepoint/ - 0 errors
 > http://localhost:4000/web-architecture/ - 0 errors
 > http://localhost:4000/workflow/ - 0 errors

Errors in http://localhost:4000/on-call/:

 • ARIA role must be appropriate for the element
   (https://dequeuniversity.com/rules/axe/3.5/aria-allowed-role?application=axeAPI)

   (#fnref:1)

   <sup id="fnref:1" role="doc-noteref"><a href="#fn:1" class="footnote...</sup>

 • ARIA role must be appropriate for the element
   (https://dequeuniversity.com/rules/axe/3.5/aria-allowed-role?application=axeAPI)

   (#fnref:2)

   <sup id="fnref:2" role="doc-noteref"><a href="#fn:2" class="footnote...</sup>

✘ 42/43 URLs passed

jadudm
jadudm approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it captures the Slack conversation, and serves as a starting point for getting more conversation going around this question.

adunkman
adunkman approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@adunkman adunkman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I added a few thoughts to the lists marked as incomplete based on my perspective. I’m 👍 with or without them!

doc/bpdr/0003-set-criteria-for-static-site-framework.md Outdated Show resolved Hide resolved
doc/bpdr/0003-set-criteria-for-static-site-framework.md Outdated Show resolved Hide resolved
@github-actions
Copy link

Pa11y testing results 
> [email protected] pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 44 URLs:
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/apis/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/on-call/ - 2 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/security/cloud-services/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
 > http://localhost:4000/security/ - 0 errors
 > http://localhost:4000/security/content-security-policy/ - 0 errors
 > http://localhost:4000/security/dependency-remediation/ - 0 errors
 > http://localhost:4000/security/output-encoding/ - 0 errors
 > http://localhost:4000/security/incident-response-drills/ - 0 errors
 > http://localhost:4000/tests/ - 0 errors
 > http://localhost:4000/sharepoint/ - 0 errors
 > http://localhost:4000/workflow/ - 0 errors
 > http://localhost:4000/web-architecture/ - 0 errors

Errors in http://localhost:4000/on-call/:

 • ARIA role must be appropriate for the element
   (https://dequeuniversity.com/rules/axe/3.5/aria-allowed-role?application=axeAPI)

   (#fnref:1)

   <sup id="fnref:1" role="doc-noteref"><a href="#fn:1" class="footnote...</sup>

 • ARIA role must be appropriate for the element
   (https://dequeuniversity.com/rules/axe/3.5/aria-allowed-role?application=axeAPI)

   (#fnref:2)

   <sup id="fnref:2" role="doc-noteref"><a href="#fn:2" class="footnote...</sup>

✘ 43/44 URLs passed

Sgtpluck
Sgtpluck approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@Sgtpluck Sgtpluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the risks!

@github-actions
Copy link

Pa11y testing results 
> [email protected] pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 44 URLs:
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/apis/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/on-call/ - 2 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/security/ - 0 errors
 > http://localhost:4000/security/cloud-services/ - 0 errors
 > http://localhost:4000/security/content-security-policy/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
 > http://localhost:4000/security/dependency-remediation/ - 0 errors
 > http://localhost:4000/security/incident-response-drills/ - 0 errors
 > http://localhost:4000/tests/ - 0 errors
 > http://localhost:4000/security/output-encoding/ - 0 errors
 > http://localhost:4000/sharepoint/ - 0 errors
 > http://localhost:4000/web-architecture/ - 0 errors
 > http://localhost:4000/workflow/ - 0 errors

Errors in http://localhost:4000/on-call/:

 • ARIA role must be appropriate for the element
   (https://dequeuniversity.com/rules/axe/3.5/aria-allowed-role?application=axeAPI)

   (#fnref:1)

   <sup id="fnref:1" role="doc-noteref"><a href="#fn:1" class="footnote...</sup>

 • ARIA role must be appropriate for the element
   (https://dequeuniversity.com/rules/axe/3.5/aria-allowed-role?application=axeAPI)

   (#fnref:2)

   <sup id="fnref:2" role="doc-noteref"><a href="#fn:2" class="footnote...</sup>

✘ 43/44 URLs passed

@echappen echappen merged commit 663f78f into main Mar 30, 2022
@echappen echappen deleted the eoc-bpdr branch March 30, 2022 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edwintorres edwintorres edwintorres left review comments

@hartsick hartsick hartsick left review comments

@Sgtpluck Sgtpluck Sgtpluck approved these changes

@jadudm jadudm jadudm approved these changes

@adunkman adunkman adunkman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@echappen @adunkman @jadudm @hartsick @edwintorres @Sgtpluck