Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Update instructions for Docker Desktop #310

Merged
merged 2 commits into from
May 24, 2022
Merged

Update instructions for Docker Desktop #310

merged 2 commits into from
May 24, 2022

Conversation

SSPJ
Copy link
Member

@SSPJ SSPJ commented May 13, 2022

No description provided.

@SSPJ
Copy link
Member Author

SSPJ commented May 13, 2022

Appears to have been bitten by pa11y/pa11y-ci#128. I'll check by running on my local when I have a free moment.

geekygirlsarah
geekygirlsarah reviewed May 13, 2022
View reviewed changes
_pages/laptop-setup.md Outdated

The docker daemon and docker CLI tools are available on a free license.

[Docker Desktop] requires a paid license. Ask in #admins-docker in Slack to get a license.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An easy way to link the Slack channel is replacing the channel with [#admins-docker](https://gsa-tts.slack.com/app_redirect?channel=admins-docker) .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sarah, added!

@geekygirlsarah
Copy link
Contributor

Appears to have been bitten by pa11y/pa11y-ci#128. I'll check by running on my local when I have a free moment.

@bklaas didn't you fight this on an issue on the guide in the past? Do you remember what you did to fix it?

@echappen
Copy link
Collaborator

Yeah pa11y fails intermittently (we need to look into why). You can try running it again and that usually works.

@Sgtpluck
Copy link
Member

This pa11y issue appears to be an issue with jekyll's default markdown generator 🙈 see relevant pr here. it seems like it's a true accessibility bug with the way it's applying the role to the footnotes of the on-call pages.

solutions are:

  • ignore it for the moment, since hopefully it will be fixed soon (it looks like someone started paying attention to that bug today)
  • contribute???
  • something complex that involves not using the default footnotes ???
  • get rid of the footnotes and add the relevant details in-line with the rest of the text

@Sgtpluck
Copy link
Member

@echappen @svenaas what do you think of the options?

@echappen
Copy link
Collaborator

For this PR in particular, I say we go with 1) ignore—fixing footnotes across the site should probably be its own issue.

@echappen echappen mentioned this pull request Dec 20, 2023
Closed
@Sgtpluck Sgtpluck merged commit ee31b73 into 18F:main May 24, 2022
@SSPJ SSPJ deleted the sspj/docker-license-change branch May 24, 2022 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@geekygirlsarah geekygirlsarah geekygirlsarah left review comments

@Sgtpluck Sgtpluck Sgtpluck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SSPJ @geekygirlsarah @echappen @Sgtpluck