-
Notifications
You must be signed in to change notification settings - Fork 122
updates GitHub action pa11y docs for jekyll and 11ty #320
Conversation
Pa11y testing results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unfamiliar with 11ty configuration, but from a content perspective this lgtm.
I also cannot add insight on the 11ty details but otherwise appreciate the contribution and think this looks good. I'm adding @kbighorse as reviewer and tagging @apburnes who has worked with 11ty and might have suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! As long as folks are ok with the dependency of start-server-and-test
. I find it very helpful, so it's definitely worth adding IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appears much better than what we had before, thanks @jduss4!
Several months ago while setting up GH Actions for an 11ty site, I discovered that the instructions in the handbook worked for jekyll but not for 11ty, which lacked a "detached" mode.
Using 11ty testing instructions from an example provided by @heymatthenry, I pulled out the shared configuration and then added sections with the specific instructions for jekyll and 11ty.
Here is the page preview in Federalist
If you were tagged as a reviewer, it's only because I don't really know who is in charge of reviewing / merging things in this repo!