This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Add suggestion to use Allstar to enforce consistency across repos #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. @Sgtpluck, you've done a fair bit of work in this file. Would you like to review as well? |
Sgtpluck
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
I think it looks good! Is it possible to add a link to where cloud.gov is using it, @markdboyd? That would be very nice to have!
|
@markdboyd perfect!!! thank you. |
|
The pa11y failure is fine as per actions/first-interaction#10 (comment) -- it's because the PR is coming from a fork. |
|
@Sgtpluck OK, thanks! I don't have access to merge PRs on this repo, so someone else will have to merge for me |
|
I have merge permission; I was just giving @kbighorse a chance to review too before we press the button. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.