Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop UUID gem in favor of SecureRandom #71

Merged
merged 1 commit into from
Jan 12, 2023
Merged

drop UUID gem in favor of SecureRandom #71

merged 1 commit into from
Jan 12, 2023

Conversation

mitchellhenke
Copy link

@mitchellhenke mitchellhenke commented Jan 12, 2023 •
edited
Loading

So that we can drop the uuid gem from the IDP

It looks like upstream made a similar change a while back

@mitchellhenke mitchellhenke requested review from a team January 12, 2023 16:09
zachmargolis
zachmargolis approved these changes Jan 12, 2023
View reviewed changes
Copy link

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchellhenke mitchellhenke merged commit a840ef3 into main Jan 12, 2023
@mitchellhenke mitchellhenke deleted the mitchellhenke/drop-uuid-gem branch January 12, 2023 16:18
orenyk
orenyk reviewed Jan 12, 2023
View reviewed changes
Copy link

@orenyk orenyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@mitchellhenke mitchellhenke mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenyk orenyk orenyk left review comments

@zachmargolis zachmargolis zachmargolis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchellhenke @zachmargolis @orenyk