README fix for PHP 7.3 installations #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current installation guide will fail for PHP 7.3, so I added this fix: It tells the user to do a composer require to version `4.6`, which will install 4.6.0. This version has an [incompatibility issue](ARCANEDEV#234) with PHP 7.3 that has been fixed in 4.6.1, so it makes sense to require that by default. Maybe there is a better solution to require the *latest stable* of 4.6 rather than setting the .1 manually. Feel free to edit this commit :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current installation guide will fail for PHP 7.3, so I added this fix: It tells the user to do a composer require to version
4.6, which will install 4.6.0. This version has an incompatibility issue with PHP 7.3 that has been fixed in 4.6.1, so it makes sense to require that by default.Maybe there is a better solution to require the latest stable of 4.6 rather than setting the .1 manually. Feel free to edit this commit :)