Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Excercises #30

Merged
merged 28 commits into from
Jul 30, 2021
Merged

New Excercises #30

merged 28 commits into from
Jul 30, 2021

Conversation

georgerahul24
Copy link
Contributor

I had added some new exercises for if and for loops.
I will add more later

Akuli
Akuli requested changes Dec 31, 2020
View reviewed changes
Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't create a new PR to fix these things. Just change this PR.

I would like some explanations to be written slightly differently, but I didn't include them in this review because I can change them myself.

basics/answers.md Outdated
pallindrome_input=input("Type the number to check:") #to get the input from user
pallindrome_check=pallindrome_input[::-1] #Reverses the string
if pallindrome_input==pallindrome_check:
print(f"This number is a pallindrome")
Copy link
Owner

@Akuli Akuli Dec 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent these with 4 spaces.

Your markdown list item (starting with 7.) is indented with 3 spaces. That too should be indented with 4 spaces, so you get 4 spaces for most lines and 4+4 spaces for indented code.

@georgerahul24
Copy link
Contributor Author

Thank you for the tips..
I will make the changes..

Akuli
Akuli requested changes Jul 2, 2021
View reviewed changes
basics/loops.md Outdated
1 2 3 4 5
```

6. Make a programme to get a pyramid like shown in the OUTPUT section where user can type the number of rows needed
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
6. Make a programme to get a pyramid like shown in the OUTPUT section where user can type the number of rows needed
6. Modify your program from the previous exercise to print this instead:

georgerahul24 and others added 4 commits July 14, 2021 01:18
@georgerahul24 @Akuli
Update basics/loops.md
33049e1 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 @Akuli
Update basics/loops.md
a509a8e 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 @Akuli
Update basics/answers.md
8fd60e4 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24
I have made the necessary changes as requested
1eeda48
@georgerahul24 georgerahul24 requested a review from Akuli July 13, 2021 20:13
Akuli
Akuli reviewed Jul 13, 2021
View reviewed changes
georgerahul24 and others added 6 commits July 14, 2021 02:06
@georgerahul24 @Akuli
Update basics/loops.md
7a93d2a 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 @Akuli
Update basics/loops.md
39f94f5 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 @Akuli
Update basics/handy-stuff-strings.md
546f769 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 @Akuli
Update basics/answers.md
afafcdb 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24
updated handy-stuff-strings.md
9f35e3a
@georgerahul24
Merge remote-tracking branch 'origin/master'
e69aad0 
# Conflicts:
#	basics/handy-stuff-strings.md
Akuli
Akuli reviewed Jul 13, 2021
View reviewed changes
@georgerahul24 georgerahul24 requested a review from Akuli July 13, 2021 21:27
Akuli
Akuli reviewed Jul 30, 2021
View reviewed changes
Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for not giving up with this and updating it over and over again as I review it!

Also, sorry about the delay. I somehow missed your request for review.

georgerahul24 and others added 2 commits July 30, 2021 22:11
@georgerahul24 @Akuli
Update basics/answers.md
7e79089 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 @Akuli
Update basics/answers.md
8cbe80f 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
georgerahul24 and others added 4 commits July 30, 2021 22:12
@georgerahul24 @Akuli
Update basics/answers.md
0e407c3 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 @Akuli
Update basics/answers.md
228c862 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 @Akuli
Update basics/answers.md
ea2f5f7 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 @Akuli
Update basics/answers.md
b9ef729 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24
Copy link
Contributor Author

georgerahul24 commented Jul 30, 2021 •
edited
Loading

Thanks a lot for helping me learn the process of adding PRs

@georgerahul24 georgerahul24 requested a review from Akuli July 30, 2021 16:45
Akuli
Akuli reviewed Jul 30, 2021
View reviewed changes
Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nits :)

georgerahul24 and others added 2 commits July 31, 2021 00:48
@georgerahul24 @Akuli
Update basics/answers.md
f8549e8 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 @Akuli
Update basics/handy-stuff-strings.md
985a52f 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 georgerahul24 requested a review from Akuli July 30, 2021 19:20
Akuli
Akuli approved these changes Jul 30, 2021
View reviewed changes
Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Akuli Akuli merged commit 18c7cea into Akuli:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgerahul24 @Akuli