-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write documentation for zip & enumerate #37
Write documentation for zip & enumerate #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks promising!
A few thoughts:
- Just put everything into the existing
trey-hunner-zip-and-enumerate.md
file: having two files for the same thing doesn't make much sense. I can rename the file once we're otherwise done, or you can rename it if you want. Feel free to delete anything that is no longer needed. - Use the
>>>
prompt for examples as in the rest of this tutorial. - Try to keep your english usage simple: something like "The keen-eyed amongst you might ask what if" should be replaced with e.g. "Let's see what happens if". Basically, imagine that people reading this are not good at english. The focus should be in learning how Python behaves, not wondering what "keen-eyed amongst" means.
Got it.. do you want me to add it at the beginning of |
Probably to the end. That's where it currently links to the article from |
…and a few minor changes
Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's making progress :)
Do you want me to squash the commits? |
You don't need to squash. I will squash when merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's becoming pretty good :)
I'm quite nit-picky in these reviews, because I really want the tutorial to be as simple as possible to follow. I basically look at this from a beginner's point of view, so things that seem easy to an experienced programmer like you often need to be explained :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I think this will be the last or second-to-last round of reviewing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I did a few more edits and renamed the file.
Added a link referring to a new detailed file about zip and enumerate functions in Trey Hunner: zip and enumerate