Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace % with f-strings in multiple files mentioned in issue #19 #41

Merged

Conversation

tusharkhatriofficial
Copy link
Contributor

No description provided.

@Akuli
Copy link
Owner

Akuli commented Sep 21, 2022

You missed one file, basics/modules.md:

basics/modules.md:The `%.2f` rounds to 2 decimals, and you can find more formatting
basics/modules.md:    print("Correct! That took %.2f seconds." % difference)
basics/modules.md:print("You are currently in %s." % os.getcwd())

(this is output from git grep % basics)

@tusharkhatriofficial
Copy link
Contributor Author

You missed one file, basics/modules.md:

basics/modules.md:The `%.2f` rounds to 2 decimals, and you can find more formatting
basics/modules.md:    print("Correct! That took %.2f seconds." % difference)
basics/modules.md:print("You are currently in %s." % os.getcwd())

(this is output from git grep % basics)

The very last commit you merged was Replace % with f-string in basics/modules.md

@tusharkhatriofficial
Copy link
Contributor Author

Please review.

Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Akuli Akuli merged commit 5183b3d into Akuli:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants