Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite editor lists in editor-setup.md #46

Merged
merged 27 commits into from
Dec 12, 2022
Merged

Conversation

georgerahul24
Copy link
Contributor

@georgerahul24 georgerahul24 commented Dec 3, 2022

Are these changes ok?
I had rewritten the part where it says bad editor to might not be suitable at this stage

Fixes #33

@georgerahul24 georgerahul24 changed the title Closes #33 Closes Akuli/python-tutorial#33 Dec 3, 2022
@georgerahul24 georgerahul24 changed the title Closes Akuli/python-tutorial#33 Closes Issue #33 (editor-setup.md is too opinionated) Dec 3, 2022
@Akuli
Copy link
Owner

Akuli commented Dec 3, 2022

I think we should rewrite the editor lists. Maybe we should have 3 categories instead of 2:

  • Relatively simple text editors that also run your code (VScode, Thonny, Porcupine, Geany, ...)
  • IDEs and editors that are likely too advanced for a beginner (Vim, Emacs, PyCharm, ...)
  • Just text editors that don't run your code (gedit, pluma, nano, notepad++, ...)

We should also mention that it doesn't matter which editor you use: everyone has their favorite editor, and there's no "right" or "wrong" choice for what editor to use.

Also, even though I am the main author of Porcupine, I don't think we should recommend it over other editors in its category. We should instead tell people to have a quick look at each editor in the list and pick their favorite.

What do you think?

@georgerahul24
Copy link
Contributor Author

I have divided into three parts like you had hinted..Is that fine?

@Akuli
Copy link
Owner

Akuli commented Dec 6, 2022

I like it! I will review in more detail later.

Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said, I really like what you wrote overall :)

This is a big pile of small nits. I mostly simplified the grammar. I want the tutorial to be usable for people who aren't good at english, so I try to write in a simple way.

georgerahul24 and others added 17 commits December 8, 2022 22:12
@georgerahul24
Copy link
Contributor Author

georgerahul24 commented Dec 8, 2022

As I said, I really like what you wrote overall :)

This is a big pile of small nits. I mostly simplified the grammar. I want the tutorial to be usable for people who aren't good at english, so I try to write in a simple way.

Its fine...going through the suggestions I do feel that the sentences are more complex than I expected them to be.

@georgerahul24
Copy link
Contributor Author

I hope that I resolved all the conflicts...Incase I left somethingg out it would be great if you could bring that to my notice..

Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last couple tweaks...

@Akuli Akuli changed the title Closes Issue #33 (editor-setup.md is too opinionated) Rewrite editor lists in editor-setup.md Dec 12, 2022
@Akuli Akuli merged commit e112702 into Akuli:master Dec 12, 2022
@Akuli
Copy link
Owner

Akuli commented Dec 12, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editor-setup.md is too opinionated
2 participants