Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve problems service functions #254

Merged
merged 1 commit into from
Jul 19, 2021
Merged

fix: improve problems service functions #254

merged 1 commit into from
Jul 19, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复 setState 需要传所有 state 的问题
  • 优化 problems 的方法及相关组件

主要变更

  • 优化 problemsService 的方法，有一些方法不需要 public，设成 private 就好了，public 的方法都是 problems 相关的方法
  • 优化 problems 相关方法的参数，支持批量增删改
  • 优化 problems 的 renderPane 调用的 View 组件，通过 connect 方法把 View 和 problemsService 连接起来，是的 state 的更新可以同步到 view 上

Related Issues

Closed #235

@wewoor wewoor added the bug Something isn't working label Jul 19, 2021
@wewoor wewoor merged commit 7382c03 into main Jul 19, 2021
@wewoor wewoor deleted the fix/problems branch July 19, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expect the function addProblems of ProblemsService supports multiple items
2 participants
@mortalYoung @wewoor