Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tree can't update root node #368

Merged
merged 1 commit into from
Aug 26, 2021
Merged

fix: tree can't update root node #368

merged 1 commit into from
Aug 26, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复 tree 组件无法修改根节点的问题

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #368 (f871855) into main (91c7b3c) will increase coverage by 0.44%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   59.48%   59.92%   +0.44%     
==========================================
  Files         173      173              
  Lines        4650     4659       +9     
  Branches     1021     1021              
==========================================
+ Hits         2766     2792      +26     
+ Misses       1864     1847      -17     
  Partials       20       20              
Impacted Files Coverage Δ
src/services/helper.ts 90.16% <0.00%> (+2.86%) ⬆️
src/model/settings.ts 100.00% <0.00%> (ø)
src/i18n/localization.ts 100.00% <0.00%> (ø)
src/workbench/editor/group.tsx 0.00% <0.00%> (ø)
src/workbench/editor/editor.tsx 31.81% <0.00%> (ø)
src/services/theme/colorThemeService.ts 100.00% <0.00%> (ø)
src/services/workbench/editorService.ts 5.46% <0.00%> (+1.58%) ⬆️
src/i18n/localeService.ts 67.27% <0.00%> (+3.12%) ⬆️
src/model/workbench/editor.ts 65.62% <0.00%> (+3.55%) ⬆️
src/controller/settings.ts 60.00% <0.00%> (+4.44%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c7b3c...f871855. Read the comment docs.

@mortalYoung mortalYoung requested a review from AndyZjy August 26, 2021 03:43
@mortalYoung
Copy link
Collaborator Author

该 helper 的测试用例未覆盖,先合并再补全

Copy link
Member

@AndyZjy AndyZjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mortalYoung mortalYoung merged commit 45fe3f6 into main Aug 26, 2021
@mortalYoung mortalYoung deleted the fix/tree-helper branch August 26, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants