-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix select all action always select the editor content #415
Conversation
Codecov Report
@@ Coverage Diff @@
## main #415 +/- ##
==========================================
- Coverage 81.27% 81.06% -0.21%
==========================================
Files 177 177
Lines 4849 4875 +26
Branches 1044 1051 +7
==========================================
+ Hits 3941 3952 +11
- Misses 899 914 +15
Partials 9 9
Continue to review full report at Codecov.
|
覆盖率差的比较大的原因是因为 action 的 run 逻辑加了很多分支判断,所以判定下来低了很多 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
关闭 Editor
后,如果不 focus 到输入控件,快捷键就无效了
那肯定无效呀 0.0 只有 |
像切换 Theme, 和 Display Language 都是不需要依赖 Editor 聚焦的 |
解决了,快捷键失效的原因是因为 id 是 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
简介
主要变更
focusin
的事件,并且 menu 新增focusinEle
属性,用于存储 menu 打开之前的保持 focus 的节点document.activeElement
取到当前 focus 的元素,然后去执行该元素的select
方法或者monaco
的selectAll
方法select
方法或者monaco
的selectAll
方法Related Issues
Closed #326