-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update tab set value #750
Conversation
Codecov Report
@@ Coverage Diff @@
## main #750 +/- ##
==========================================
+ Coverage 91.34% 91.40% +0.06%
==========================================
Files 189 189
Lines 5947 5966 +19
Branches 1426 1435 +9
==========================================
+ Hits 5432 5453 +21
+ Misses 508 506 -2
Partials 7 7
Continue to review full report at Codecov.
|
return updatedTab; | ||
} | ||
|
||
public setGroupEditorValue(group: IEditorGroup, value: string) { | ||
const modal = group.editorInstance?.getModel(); | ||
if (!modal) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!modal) return; | |
if (!model) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
1299ff1
to
25717bd
Compare
+1 |
Description
Can't update editor's value via the updateTab method
Fixes #714
Changes
editorInstance.onDidChangeModelContent
added comparisons are made through URIs to limit changes to different editors。This is because when you change the contents of the editor with setValue, the onDidChangeModelContent event is triggered, and leaving it unchecked will cause the updateTab method to be called in onDidChangeModelContent, causing a circular callHow Has This Been Tested?
Checklist