Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: the text of the optimized tree item is too long #773

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

Zaoei
Copy link
Collaborator

@Zaoei Zaoei commented Jul 8, 2022

Description

Text too long, out of width

Fixes #743

Changes

Text out of width, showing ellipsis

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Zaoei Zaoei requested review from mumiao, mortalYoung and wewoor July 8, 2022 01:55
@Zaoei Zaoei self-assigned this Jul 8, 2022
@Zaoei Zaoei added the bug Something isn't working label Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #773 (c3169f6) into main (6a8e109) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #773   +/-   ##
=======================================
  Coverage   91.64%   91.65%           
=======================================
  Files         191      191           
  Lines        5866     5869    +3     
  Branches     1404     1405    +1     
=======================================
+ Hits         5376     5379    +3     
  Misses        484      484           
  Partials        6        6           
Impacted Files Coverage Δ
src/services/instanceService.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a8e109...c3169f6. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

静态检查失败了

@Zaoei Zaoei force-pushed the fix/tree_item_title_ellipsis branch from fcbdc7a to c3169f6 Compare July 8, 2022 02:35
@Zaoei
Copy link
Collaborator Author

Zaoei commented Jul 8, 2022

静态检查失败了

新增加的样式需要在 width 之前,已修改

@wewoor wewoor merged commit 32c877a into DTStack:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: folder's name is hidden in folderTree
2 participants