Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove todos #794

Merged
merged 1 commit into from
Aug 30, 2022
Merged

chore: remove todos #794

merged 1 commit into from
Aug 30, 2022

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 移除不必要的注释

主要变更

对该注释内容做如下解释

  1. 默认事件渲染两次,无法复现
  2. 我们没有必要去探知用户是否执行,换个角度想,其实 subscribe 和 emit 的机制就是单方面的通知。
  3. 推测第一条是为了防止同一个事件,Molecule 执行,用户也定义执行,导致执行两次。这种情况除了这里存在,其他地方也存在。用户应该规避这种情况的出现。

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 91.04% // Head: 91.04% // No change to project coverage 👍

Coverage data is based on head (f41991b) compared to base (80d99bc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #794   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files         180      180           
  Lines        5787     5787           
  Branches     1402     1402           
=======================================
  Hits         5269     5269           
  Misses        512      512           
  Partials        6        6           
Impacted Files Coverage Δ
src/controller/menuBar.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mumiao mumiao merged commit 4856c91 into main Aug 30, 2022
@mumiao mumiao deleted the fix/menuBar branch August 30, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants