Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.0 #310

Merged
merged 55 commits into from
Apr 22, 2022
Merged

v2.1.0 #310

merged 55 commits into from
Apr 22, 2022

Conversation

BeeGass
Copy link
Contributor

@BeeGass BeeGass commented Apr 22, 2022

Added PathMLLogger. This enables users and developers to look at pathml specific logs. This includes customizing logger (check docs for options) and chose of log output, i.e. terminal or log file.

ryanccarelli and others added 30 commits February 8, 2022 20:28
…he project. Also encorporated the ability to turn 'dev mode' on/off so that logging for pathml isnt done for users using the library. Work still needs to be done in logging more of the project
…ing before with how levels, filters and how they work with handlers within loguru. That has since been remedied
…are now being generated but still testing to have everything fully functional.
…d'ing into it. Also changed the notebook to include the images to download.
…nt file path and remove logs that have already been saved to examples directory
…remove logs that have already been saved to examples directory
…ing, doc creation and everything else is working on my end
…r functional logging which pass. logger_wraps have been removed from all functions. An absolute file path has been set for log
…hich supports the custimization of a single handler
@BeeGass BeeGass requested a review from jacob-rosenthal April 22, 2022 18:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #310 (a3cceaf) into master (65ecf6c) will decrease coverage by 0.41%.
The diff coverage is 73.64%.

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   86.93%   86.51%   -0.42%     
==========================================
  Files          26       27       +1     
  Lines        2441     2529      +88     
==========================================
+ Hits         2122     2188      +66     
- Misses        319      341      +22     
Impacted Files Coverage Δ
pathml/preprocessing/__init__.py 100.00% <ø> (ø)
pathml/core/slide_data.py 85.04% <50.00%> (-0.34%) ⬇️
pathml/datasets/deepfocus.py 53.03% <50.00%> (+0.72%) ⬆️
pathml/ml/utils.py 59.74% <50.00%> (+0.52%) ⬆️
pathml/_logging.py 60.60% <60.60%> (ø)
pathml/preprocessing/transforms.py 88.81% <66.66%> (+0.09%) ⬆️
pathml/datasets/pannuke.py 88.74% <71.42%> (+0.30%) ⬆️
pathml/core/h5managers.py 81.97% <75.00%> (+0.10%) ⬆️
pathml/core/slide_backends.py 91.42% <79.06%> (-1.74%) ⬇️
pathml/__init__.py 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ecf6c...a3cceaf. Read the comment docs.

@jacob-rosenthal
Copy link
Collaborator

Great thanks Bryan!!

  • Bump the version in pathml/_version.py
  • Can you please add one-line notes for the other PRs that were merged since the last release?

@jacob-rosenthal jacob-rosenthal merged commit f8789b9 into master Apr 22, 2022
@jacob-rosenthal jacob-rosenthal deleted the v2.1.0 branch April 22, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants