Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/otlp] Skip faulty test on macOS #12502

Merged
merged 1 commit into from
Jun 23, 2022
Merged

[pkg/otlp] Skip faulty test on macOS #12502

merged 1 commit into from
Jun 23, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jun 23, 2022

What does this PR do?

Skip TestStartPipelineFromConfig on macOS.

Motivation

The test currently fails on a sync error, as described on open-telemetry/opentelemetry-collector/issues/4153.
This needs to be fixed upstream (see open-telemetry/opentelemetry-collector/pull/5585) before removing the skip.

Additional Notes

Test started failing after #12281.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@mx-psi mx-psi requested a review from a team as a code owner June 23, 2022 10:51
@mx-psi mx-psi added changelog/no-changelog [deprecated] team/agent-platform [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card component/otlp PRs and issues related to OTLP ingest labels Jun 23, 2022
@mx-psi mx-psi added this to the 7.38.0 milestone Jun 23, 2022
@mx-psi mx-psi requested a review from keisku June 23, 2022 11:17
Copy link
Contributor

@amenasria amenasria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi merged commit db9af5f into main Jun 23, 2022
@mx-psi mx-psi deleted the mx-psi/fix-sync-issue branch June 23, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/otlp PRs and issues related to OTLP ingest [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants