-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Django 1.7 #129
Update to Django 1.7 #129
Conversation
@@ -75,6 +75,8 @@ You will notice that a new `blog` directory is created and it contains a number | |||
└── blog | |||
__init__.py | |||
admin.py | |||
migrate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The folder is called migrations
and I think we should put it above __init__.py
in the listing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uups, too sleepy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this?
djangogirls
├── mysite
| __init__.py
| settings.py
| urls.py
| wsgi.py
├── manage.py
└── blog
├── migrations
| __init__.py
├── __init__.py
├── admin.py
├── models.py
├── tests.py
└── views.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't quite tell why but it looks weird.
The |
for migrations/__init__.py
seems like it should be aligned somewhere else but I can't tell how.
Do you know if we have other examples of a deep folder hierarchy in our tutorial?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran rgrep but it seems like the only one is here
I've updated the README with the folder structure, I think that the pipe looks weird because of the height difference. Please have a look at that now |
Password (again): | ||
Superuser created successfully. | ||
|
||
Return to your browser and log in with the superuser's credentials you chosed, you should see the Django admin dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"... credentials you chose, you ..." (chose w/o trailing d)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! updated
Thanks! :) 👍 |
Starting point for #122