Send wakeup keycode alongside trying to turn screen on when restoring

[brunoais]

No description provided.

[brunoais]

@rom1v Is it better this way? It works too with my phone.

[rom1v]

My first thought was it was incorrect to reset the power mode to normal only when the screen is on: I still want to be able to physically turn the screen on with a double tab on the screen (without pressing POWER)¹. If the screen is not reset to normal, I thought it would not work.

In fact, it's the opposite:

• double tab allows to turn the screen on even if power mode is not NORMAL;
• setting power mode to NORMAL while screen is off is not handled correctly, so this breaks "screen on on double tab".

Therefore, I agree with this change. I made isScreenOn() static (0c5e0a4) then adapted your commit: 0bf110d.

Could you please review/test? (branch pr1670)

¹ Btw, turning the screen on with a double tap (only supported on some devices) is not catched by #1577.

[brunoais]

double tab allows to turn the screen on even if power mode is not NORMAL;

Doesn't work on my phone. I need this API to turn it back on, otherwise, the double-tab turns off and locks and then double-tab turns it back on.

then adapted your commit: 0bf110d.

LGTM.

Btw, turning the screen on with a double tap (only supported on some devices) is not catched by #1577.

True, that's by design. #1577, by design, is intended to act only for actions done in scrcpy. Do you think the documentation requires more clarification?

[rom1v]

LGTM.

👍 Merged into dev.

Doesn't work on my phone. I need this API to turn it back on, otherwise, the double-tab turns off and locks and then double-tab turns it back on.

Sorry, I don't get it.

With the following steps:

• scrcpy --turn-screen-off (physical screen off, mirror screen on)
• Alt+p (physical screen off, mirror screen off)
• close scrcpy
• double-tap on the physical screen

Without this change, it stays black. With this change, it works. (Initially, I thought it would be the contrary)

True, that's by design.

👍

Btw, double-tap with a double-click in scrcpy works to turn the screen off, but not to turn it back on.

[brunoais]

With the following steps:

* `scrcpy --turn-screen-off` (physical screen off, mirror screen on)
* Alt+p (physical screen off, mirror screen off)
* close scrcpy
* double-tap on the physical screen

Without this change, it stays black. With this change, it works. (Initially, I thought it would be the contrary)

Without this change:
On my phone, that 3rd step would turn the screen and display on; ready to unlock. Then the double-tap would turn the screen off.
Closing scrcpy turns on the screen and the display.

Seems like in phones like yours, only the screen turns on but not the display (no image but light on). However, the OS changes mode to "awaken" (or whatever name). So when you double-tap it, it turns off both screen and display.

With this change:
I guess we get consistent behavior because now my phone behaves as you describe in the quote above.
If the display is on but the screen if off, the screen is turned back on.
If both display and screen are off, they stay off.

Makes sense?