Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass arguments through to scrcpy.exe #2052

Closed
wants to merge 1 commit into from

Conversation

slingmint
Copy link
Contributor

No description provided.

rom1v pushed a commit that referenced this pull request Jan 22, 2021
@rom1v
Copy link
Collaborator

rom1v commented Jan 22, 2021

Thank you 👍

However, it did not correctly handled arguments with spaces (like --window-title "a b c"), so I added quotes. And I simplified a bit.

Please review: pr2052

Copy link
Contributor Author

@slingmint slingmint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. And, yes, I'm not sure how I forgot about adding quotes, but good catch. Looks good to me.

@rom1v
Copy link
Collaborator

rom1v commented Jan 23, 2021

Oh but my version does not work in case the parsed arguments already contain ".

For example, --window-title="a b c" does not work, while --window-title "a b c" works.

EDIT: ah in fact it works, --window-title="a b c" is passed as --window-title=a b c in argv.

@rom1v
Copy link
Collaborator

rom1v commented Jan 23, 2021

I fail to pass a real double-quote (for example a window title "abc" with " included) as argument correctly:

scrcpy           --window-title="""a b c"""  REM works
scrcpy-noconsole --window-title="""a b c"""  REM does not work

https://superuser.com/a/962805/310383

@rom1v
Copy link
Collaborator

rom1v commented Mar 16, 2021

--window-title "a b c" works correctly, that's good enough 👍

Merged into dev: dd453ad

@rom1v rom1v closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants