coreos/azure: Weave version bump, various other enhancements #7224
+77
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems a little odd, sometimes we get an error that node had already been registered... it's unclear whether kubelet somehow does self-registration?
It turns out `network-online.target` doesn't imply that there is access to the Internet and simply using `curl --retry 10` doesn't work and hangs forever, even if we can already reach github.com...
|
LGTM |
roberthbailey
added a commit
that referenced
this pull request
Apr 24, 2015
coreos/azure: Weave version bump, various other enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a big thanks to @idosh for keeping this up-to-date (#7074 & #7158), here is a follow-up with some more improvements.