Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qlImageSize.qlgenerator v1.6.0 #57212

Closed
wants to merge 2 commits into from
Closed

add qlImageSize.qlgenerator v1.6.0 #57212

wants to merge 2 commits into from

Conversation

L1cardo
Copy link
Contributor

@L1cardo L1cardo commented Jan 9, 2019

Owner no longer provides compiled versions. So the homepage is the origin owner's repo , and the url is my repo, like below

2019-01-09 1 51 37

I really hope it can be merged , thanks !

Verified

This commit was signed with the committer’s verified signature.
stasadev Stanislav Zhuk
@reitermarkus
Copy link
Member

From #57125:

It is not possible for me to convince the owner.

What did upstream say?

@L1cardo
Copy link
Contributor Author

L1cardo commented Jan 9, 2019

From #57125:

It is not possible for me to convince the owner.

What did upstream say?

He said he won't make any build . He demands people to compile by themselves .
2019-01-09 9 31 36
2019-01-09 9 34 16

Verified

This commit was signed with the committer’s verified signature.
stasadev Stanislav Zhuk
@L1cardo
Copy link
Contributor Author

L1cardo commented Jan 9, 2019

Since the owner will not host the project , I will host it .
So , the homepage and url should be my repo

@vitorgalvao
Copy link
Contributor

Since the owner will not host the project , I will host it .
So , the homepage and url should be my repo

No, we cannot accept that. That would be deceiving to our users, making it seem like this is official, when in fact it is not. We have no guarantee you won’t suddenly turn and include malware in your version.

Your version is quite below the acceptable threshold (50 stars), but given the circumstances I’d be willing to ignore that this time if the other maintainers think it’s worth it. My take is that we shouldn’t do it yet.

But even so, for us to accept your version, it has to:

  1. Add an appcast.
  2. Be an actual direct fork of the original project (right now it seems like you made a new repo and copied the code).
  3. Be renamed like a fork (which it effectively is).

Also please do not delete templates in place; they exist for a reason.

@vitorgalvao
Copy link
Contributor

Closing for lack of interest.

sindresorhus added a commit to sindresorhus/quick-look-plugins that referenced this pull request Jan 25, 2019

Verified

This commit was signed with the committer’s verified signature.
stasadev Stanislav Zhuk
See Homebrew/homebrew-cask#57212

Closes #93
Closes #92
Closes #94
Closes #95
@MartinDelille MartinDelille mentioned this pull request Feb 19, 2019
10 tasks
@lock lock bot added the outdated label Feb 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants