-
-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#314 Red dislike button when clicked (instead of blue) #371
Conversation
Adding support of changing Dislike button color red
Please avoid using JavaScript functions for features that might work in CSS. |
You mean addition of css class for element color and use that class in js? |
red_dislike_button: {
type: 'switch',
label: 'redDislikeButton'
}
html[it-red-dislike-button='true'] YOUR_QUERY {
/* YOUR_STYLES */
}
"redDislikeButton": {
"message": "Red dislike button"
} |
Popup-menu re-structuring: Strictly people who dont click on details>'likes'(thumbs) also wont want to see this feature? (No accidental dislike can do too much harm) . So it can belong inside the likes-item? As another option there. Then some people could miss ability to set 'icons only + turn red when I disliked'. So 'Likes' could also be type='folder' with 3 switches, but then it takes one click more (to go back from likes). |
Closing this PR as I've raised another PR https://github.com/ImprovedTube/ImprovedTube/pull/455/files for the same. |
Thanks! @victor-savinov @priyank780 We are looking forward to more people trying these easy steps.Example:Somebody wished: "Would it be possible to get an option to make the sidebar on the left side?" CSS Solution: 2 Files edited (2 Commits): /src/youtube/css/appearance.css(your CSS & JS can be tested with ImprovedTube's developer feature (next to Browser console). (Or on any site with our "Dark Mode" extension ) ( Newbies: CSS names of elements on websites can be explored with right click ("inspect") ) And 2. for our GUI: src/template/js/template-parts/appearance.js - also resorting the sidebar section along the way by size of visual change ~ priority ~ popularity Steps to edit ImprovedTube & Popup Menu
...about 2. : We can think ahead of some YouTube changes. ...about 3. : we have a build-script to add your message to all languages files: github/ImprovedTube/locale.py (to test the whole extension, we combine the source files ( /src/ ) (into content-scripts.js & popup.js) using our build.py since fewer files can reduce use of IOPS, since storage devices are most computer's speed bottlenecks and can wear down...) |
Adding support of changing Dislike button color red