fix PHP 8.4 deprecation error (implicitly nullable parameter) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JimTools shameless bump |
|
@mbolli not at all! I’m still supporting V1 as I know it’s widely used but’s highly unlikely I’m going to back port features unless critical. |
|
@JimTools not sure if I understand correctly. do you want to say this is a feature (and therefore won't be merged) or this is providing support and you will merge it because it's still highly used? ;-) |
|
@mbolli sorry for the detail I will merge this I just need to update the ci the also run against 8.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope you don't mind another 1.x release ;-)