Add TS004F / _TZ3000_nuombroo #6303
Merged
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah sorry I’m not entirely sure how to set this up it looks like. Should I remove the model field from both objects? |
Koenkk
reviewed
Oct 18, 2023
| 'Operation mode: "command" - for group control, "event" - for clicks'), | ||
| e.action(['on', 'off', 'brightness_step_up', 'brightness_step_down', 'brightness_move_up', | ||
| 'brightness_move_down', '1_single', '1_double', '1_hold', '2_single', '2_double', '2_hold', | ||
| '3_single', '3_double', '3_hold', '4_single', '4_double', '4_hold'])], |
There was a problem hiding this comment.
Do the actions depend on the operation_mode? (command = on/off, etc, event=1_double`, etc.)?
If this is the case my previous statement was wrong and you can merge these.
There was a problem hiding this comment.
Yeah, exactly. In command mode the device will broadcast the specific action messages to the group (on, off etc) but in event mode it sends special frames handled by tuya_on_off_action in fromZigbee.
EDIT: Ah wait I see what you're saying now. Yes I'll get this merged into the other entry.
6d41e0a to
459e6ee
Compare
459e6ee to
3129fc0
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Koenkk/zigbee2mqtt#19327 by adding support for _TZ3000_nuombroo