Split AnnotatedQueue from QueuingContext
#2794
Merged
+221
−347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Jul 5, 2022
Codecov Report
@@ Coverage Diff @@
## master #2794 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 272 272
Lines 23133 23122 -11
==========================================
- Hits 23057 23046 -11
Misses 76 76
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mlxd
approved these changes
Jul 18, 2022
albi3ro
commented
Sep 12, 2022
albi3ro
commented
Sep 12, 2022
albi3ro
commented
Sep 12, 2022
albi3ro
commented
Sep 12, 2022
AlbertMitjans
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
QuantumTapeinherits fromAnnotatedQueuewhich inherits fromQueuingContext. This leads to a great deal of confusion about where functionality is defined and what methods are supposed to be doing.This PR does not change any PennyLane behaviour, but just improves internal structure and clarity.
In this PR,
QueuingContextis no longer an abstract base classAnnotatedQueueno longer inherits fromQueuingContextQueuingContextpurely consists of class methods and a private class property.QueuingContextis no longer a context. It only manages recording contexts. We should later rename it toQueueManagerQueuingContext._active_contextsis now a list instead of adeque. Deque was confusing overkill when a list gets the job done perfectly well_append,_remove,_get_info,_update_info, and_safe_update_infoare removed. They just caused confusing indirection.AnnotatedQueueandQuantumTapewill no longer provide global information about actively recording queues. This information was unused via those classes and just caused unnecessary duplication.OperationRecorderare now intests/tape/test_operation_recorder.py, mirroring the location of the class in the code base.