Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the pylint test pre-commit hook #4127

Merged
merged 1 commit into from
May 15, 2023
Merged

remove the pylint test pre-commit hook #4127

merged 1 commit into from
May 15, 2023

Conversation

timmysilv
Copy link
Contributor

It sucks as is. CI will still fail if you violate our test linting requirements, but this doesn't happen often enough to merit enduring this pre-commit hook. Making a better hook is non-trivial as it stands, so we can look into this later. I'll open a draft PR once this is merged and see what I can do, but for now, we should disable it

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@timmysilv timmysilv requested a review from a team May 15, 2023 17:09
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make my life so much easier. Thanks for opening this PR up.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #4127 (902b0a8) into master (c39595f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4127   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         345      345           
  Lines       30864    30864           
=======================================
  Hits        30792    30792           
  Misses         72       72           

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timmysilv timmysilv merged commit 1a1b070 into master May 15, 2023
@timmysilv timmysilv deleted the remove-test-hook branch May 15, 2023 18:55
timmysilv added a commit that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants