Enable CI and pre-commit hook to lint tests #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #4335 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 351 351
Lines 32058 32058
=======================================
Hits 31991 31991
Misses 67 67 |
mudit2812
reviewed
Jul 7, 2023
mudit2812
approved these changes
Jul 7, 2023
eddddddy
reviewed
Jul 7, 2023
dwierichs
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Thanks for moving on with this @timmysilv, very nice to see the custom test linting logic leave! :) 💯
Couldn't find anything to remark, lgtm :)
mudit2812
pushed a commit
that referenced
this pull request
Jul 10, 2023
* rename all legacy test files to match pylint pattern * pylint all tests in CI and pre-commit * lint legacy/qnn/conftest * remove the custom pylint test handling * run black before pylint * changelog --------- Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
mudit2812
added a commit
that referenced
this pull request
Jul 11, 2023
* Adding changes for shift rules * Testing changes * Fixed op indices * Fixed indexing * Updated `bind_new_parameters` * Updated `tape.get_operation` * Updated tests * Test updates; multishifting works * Fixing interface * Updated shifting; added dispatch for templates * Updated shifting function * Fixed index error * Removed commented code * [skip ci] Reverted changes to `bind_new_parameters * Update to remove copying * Update changelog * Apply suggestions from code review Co-authored-by: Matthew Silverman <matthews@xanadu.ai> * Removed unused import * Roll back suggested change * Remove state vector support from `math/quantum.py` (#4322) * Remove statevector support for qinfo functions * remove unused funcs * Fix some tests * pylint * more pylint * Remove unnecessary log * Changelog and deprecations entry * trigger ci * Enable CI and pre-commit hook to lint tests (#4335) * rename all legacy test files to match pylint pattern * pylint all tests in CI and pre-commit * lint legacy/qnn/conftest * remove the custom pylint test handling * run black before pylint * changelog --------- Co-authored-by: David Wierichs <david.wierichs@xanadu.ai> * Update broadcasting transforms to use `bind_new_parameters` (#4288) * use bind_new_parameters * pylint * remove batching in measurements and add tests * More coverage issues * Add uncopied tests * Helper function * pylint * Make tape._ops public * use private methods * pylint * Add more docs to split_operations * pylint * Deprecate X and P (#4330) * update in docs * update changelog * Test warning is raised * update default gaussian device * update tests * update more tests * fix legacy tests * Specify v0.33 removal in docstring * Render X and P in docs * move deprecation warning in docstring * fix sphinx linking * add warning box * Support wire labels in `qinfo` transforms (#4331) * Support wire labels in qinfo transforms * changelog * pylint and update test * add bugfix entry * Deprecations for 0.32 from me! (#4316) * deprecate the old return system * deprecate the mode kwarg for QNode * changelog * PR feedback * update notice to avoid wrongly suggesting action needed * update docstrings, docs and warnings * add link to qnode returns doc * change the mode warning depending on return system active * also add disclaimer to docstring --------- Co-authored-by: Matthew Silverman <matthews@xanadu.ai> Co-authored-by: Edward Jiang <34989448+eddddddy@users.noreply.github.com> Co-authored-by: David Wierichs <david.wierichs@xanadu.ai> Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A million thank-you's to @dwierichs for putting in all the work to get us here!!
All tests (but legacy) have been linted, and we can now enable test linting across the board. Unfortunately, the pylint file filter does not work as expected, so I had to rename all the legacy test files (not the folder they're in) to be named
test_legacy_*instead oftest_*for any filter to catch them, but this is minor since it's only for stale legacy test files.Changes: