Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for active subscription to determine billing version #12330

Merged
merged 17 commits into from
Oct 19, 2022

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Oct 19, 2022

Problem

We get_or_create billing for V1 so we need to actually check the subscription.

Changes

  • Fixes this
  • Also checks license key type before trying to use it to contact billing service

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Part of Cloud so hard to test....

@benjackwhite benjackwhite requested a review from kappa90 October 19, 2022 07:58
@benjackwhite benjackwhite enabled auto-merge (squash) October 19, 2022 07:58
@benjackwhite benjackwhite requested a review from macobo October 19, 2022 08:30
@benjackwhite benjackwhite removed the request for review from macobo October 19, 2022 09:17
@benjackwhite benjackwhite merged commit 683a4aa into master Oct 19, 2022
@benjackwhite benjackwhite deleted the feat/billing-followup branch October 19, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants