feat: simplify the docker-compose setup so we do less version coordinations #12998
+125
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the hobby CI. It's broken and needs fixing (there is a prompt for input while installing dependencies now) |
docker-compose.base.yml
Outdated
| @@ -0,0 +1,63 @@ | |||
| # | |||
| # docker-compose file used ONLY for local development. | |||
There was a problem hiding this comment.
Not sure if this comment is accurate
guidoiaquinti
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #12997
This moves from
docker-composetodocker composewhich is how github differentiates between v1 and v2Problem
This makes it easier by having a base docker-compose template for development by using
extends. Very exciting!https://github.com/compose-spec/compose-spec/blob/master/spec.md#extends
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?