Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Temporal service waits for db to be healthy #16079

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

tomasfarias
Copy link
Contributor

@tomasfarias tomasfarias commented Jun 15, 2023

Problem

In the CI logs of a recent failure we see:

posthog-temporal-1     | 2023-06-15T11:15:54.088Z	ERROR	Unable to create SQL database.	{"error": "unable to connect to DB, tried default DB names: postgres,defaultdb, errors: [pq: the database system is starting up pq: the database system is starting up]", "logging-call-at": "handler.go:94"}

Changes

Let's add a healthcheck to the db service and wait for it to be healthy for temporal to run.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@tomasfarias tomasfarias force-pushed the fix/temporal-wait-for-db branch from 7724042 to 28ab42e Compare June 15, 2023 11:41
@tomasfarias tomasfarias changed the title fix: Temporal dev service waits for db to be healthy fix: Temporal service waits for db to be healthy Jun 15, 2023
@tomasfarias tomasfarias marked this pull request as ready for review June 15, 2023 12:04
@tomasfarias tomasfarias requested a review from a team June 15, 2023 12:04
@hazzadous
Copy link
Contributor

@tomasfarias I'm going to yolo this in! See if it doesn't help with the failures.

@hazzadous hazzadous merged commit 8f77da2 into master Jun 16, 2023
@hazzadous hazzadous deleted the fix/temporal-wait-for-db branch June 16, 2023 06:43
@tomasfarias
Copy link
Contributor Author

@hazzadous Thanks for reviewing! Just wanted to make sure someone looked at my docker-compose changes in case I break the stack.

All for merging this in and checking out if it helps!

@hazzadous
Copy link
Contributor

Yeah sorry I woke up trigger happy :/ I don't think it's a good thing. Very rude.

@tomasfarias
Copy link
Contributor Author

@hazzadous I didn't take anything the wrong way, I'm all for merging stuff. Thank you 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants