Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compose): add capture-rs profile with containerised capture for testing #18140

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Oct 23, 2023

Problem

We'll want to run capture-rs in the local devenv for manual integration testing. Instead of adding a rustc dependency right now, let's use the docker image.

It uses the new profiles feature, so it's not started by default. You can get it up with docker compose -f docker-compose.dev.yml --profile capture-rs up -d

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@xvello xvello marked this pull request as ready for review October 23, 2023 14:58
@xvello xvello requested a review from ellie October 23, 2023 14:58
Copy link
Contributor

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@xvello xvello force-pushed the xvello/capture-compose branch from 315ba3c to 970e771 Compare October 25, 2023 15:27
@xvello xvello merged commit 886c804 into master Oct 25, 2023
@xvello xvello deleted the xvello/capture-compose branch October 25, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants