Skip to content

use just instead of make command runner and use uv#17149

Merged
zzstoatzz merged 5 commits intomainfrom
justfile
Feb 21, 2025
Merged

use just instead of make command runner and use uv#17149
zzstoatzz merged 5 commits intomainfrom
justfile

Conversation

@zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Feb 14, 2025

the Makefile was just incorrectly trying to serve docs, so this is not currently used and just is a nice alternative to make IME - any thoughts?

install just

» just -l
Available recipes:
    check-uv # Check for uv installation
    docs     # Build and serve documentation
    install  # Install development dependencies
    clean    # Clean up

also removes .ruff.toml as corresponding config now lives in pyproject.toml

if you don't have uv installed, you'll see this message (if on macOS)

» just install
uv is not installed or not found in expected locations.
To install uv on macOS, run one of:
• brew install uv
• curl -LsSf https://astral.sh/uv/install.sh | sh
• pip install uv
• pipx install uv
error: Recipe `check-uv` failed with exit code 1

this PR also removes the old script that the Makefile was trying to use and removes another old script that was currently failing for all of recent past in CI every night

@desertaxle
Copy link
Member

I like the premise of having simple commands to run for common tasks, but I'm hesitant to introduce another pre-requisite tool that contributors need to install manually. Could just automatically install uv?

@zzstoatzz
Copy link
Collaborator Author

I'm hesitant to introduce another pre-requisite tool that contributors need to install manually.

i wasn't thinking that contributors would have to install it, but that's a good point since ideally this would be a public to contributors thing. i thought it might be fine since the only command in this file now was broken/unused afaik

Could just automatically install uv?

yes i think so! i could update this to install if not present

Base automatically changed from pyproject-v2 to main February 18, 2025 18:19
@desertaxle
Copy link
Member

I like that you can list the available recipes, which makes me think this could be a great tool for reducing friction for contributors as long as we can use it to automate another tool setup.

I think you might need to rebase though.

@zzstoatzz zzstoatzz closed this Feb 19, 2025
@zzstoatzz zzstoatzz deleted the justfile branch February 19, 2025 16:43
@zzstoatzz zzstoatzz restored the justfile branch February 19, 2025 16:43
@zzstoatzz zzstoatzz reopened this Feb 19, 2025
@zzstoatzz zzstoatzz force-pushed the justfile branch 2 times, most recently from 3717cfc to e1e60d4 Compare February 21, 2025 00:03
@zzstoatzz zzstoatzz merged commit 65a4ba2 into main Feb 21, 2025
10 checks passed
@zzstoatzz zzstoatzz deleted the justfile branch February 21, 2025 17:11
@zzstoatzz zzstoatzz mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants