Add support for Python 3.12

[hugovk]

The second Python 3.12 release candidate is out! 🚀

Call to action

We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.12 compatibilities during this phase, and where necessary publish Python 3.12 wheels on PyPI to be ready for the final release of 3.12.0.

Python 3.12.0 final is due out in two weeks: 2023-10-02.

See also https://dev.to/hugovk/help-test-python-312-beta-1508/

[codecov]

Codecov Report

Merging #2175 (0ef29df) into main (f61affa) will not change coverage.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2175   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          38       39    +1     
  Lines        3089     3089           
  Branches      748      748           
=======================================
  Hits         3063     3063           
  Misses         15       15           
  Partials       11       11           

[jfcherng]

Get this today after upgrading to py312. I can continue to use py_version = 311 though.

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "D:\jfcherng\Desktop\repos\sdlc\app_launcher\.venv\Scripts\isort.exe\__main__.py", line 7, in <module>
  File "D:\jfcherng\Desktop\repos\sdlc\app_launcher\.venv\Lib\site-packages\isort\main.py", line 1121, in main
    config = Config(**config_dict)
             ^^^^^^^^^^^^^^^^^^^^^
  File "D:\jfcherng\Desktop\repos\sdlc\app_launcher\.venv\Lib\site-packages\isort\settings.py", line 528, in __init__
    super().__init__(sources=tuple(sources), **combined_config)
  File "<string>", line 105, in __init__
  File "D:\jfcherng\Desktop\repos\sdlc\app_launcher\.venv\Lib\site-packages\isort\settings.py", line 261, in __post_init__
    raise ValueError(
ValueError: The python version 312 is not supported. You can set a python version with the -py or --python-version flag. The following versions are supported: ('all', '2', '27', '3', '310', '311', '36', '37', '38', '39')

pyproject.toml

[tool.isort]
py_version = 312

[staticdev]

Please all those action versions changes are not relevant for supporting 3.12. Just keep relevant changes in this PR.

[hugovk]

Sure, would you like them in another PR?

[staticdev]

Even better would be automate version update PRs with:
https://github.com/staticdev/ansible-role-pyenv/blob/main/.github/dependabot.yml#L4

[hugovk]

Yes, much better idea :)

[staticdev]

Even better would be automate version update PRs with:
https://github.com/staticdev/ansible-role-pyenv/blob/main/.github/dependabot.yml#L4

[staticdev]

Thanks a lot @hugovk I just have a final comment on your PR, other than that LGTM.

[Guerteltier]

Wouldn't it be better to actually add support for 3.12 instead of just pretending? (#2175 (comment))
I don't see how this pull request helps anyone.

[hugovk]

Ah right, we need to update and run scripts/mkstdlibs.py.

I did so and got this error:

Traceback (most recent call last):
  File "/private/tmp/isort/scripts/mkstdlibs.py", line 40, in <module>
    invdata = fetch_inventory(FakeApp(), "", url)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/sphinx/ext/intersphinx.py", line 183, in fetch_inventory
    f = _read_from_url(inv, config=app.config)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/sphinx/ext/intersphinx.py", line 140, in _read_from_url
    _tls_info=(config.tls_verify, config.tls_cacerts))
                                  ^^^^^^^^^^^^^^^^^^
AttributeError: ('intersphinx inventory %r not fetchable due to %s: %s', 'https://docs.python.org/2.7/objects.inv', <class 'AttributeError'>, "'FakeConfig' object has no attribute 'tls_cacerts'")

Downgrading from latest Sphinx 7.2.6 to 6.2.1 worked fine. It also updated the 3.11 list.

[staticdev]

I just added a new suggestion and if possible could you rebase since we merged some other changes?

[hugovk]

Let's also remove unsupported versions.

Also remove their old files from https://github.com/PyCQA/isort/tree/main/isort/stdlibs?

[staticdev]

Let's also remove unsupported versions.

Also remove their old files from https://github.com/PyCQA/isort/tree/main/isort/stdlibs?

py2 and py27 yes.

[hugovk]

I decided not to remove them after all, a lot of tests would need updating so I think it's out of scope for this PR.