-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix make lint-docstrings #12441
Fix make lint-docstrings #12441
Conversation
f328b90
to
635ab35
Compare
635ab35
to
45a65a0
Compare
45a65a0
to
5f59746
Compare
scripts/lint_python_docstrings.sh
Outdated
# Compare against `main` if no branch was provided | ||
BRANCH="${1:-main}" | ||
|
||
echo "2-here" | ||
# Diff of committed changes (shows only changes introduced by your branch | ||
FILES_WITH_DIFF=`git diff $BRANCH...HEAD --name-only -- rasa | grep -e '\.py$' | xargs echo -n` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's the offending commit 4aefb5f
ae5315a
to
8daf3cb
Compare
8daf3cb
to
fe3cdc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the fix
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)