Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make lint-docstrings #12441

Merged
merged 1 commit into from
May 23, 2023
Merged

Fix make lint-docstrings #12441

merged 1 commit into from
May 23, 2023

Conversation

m-vdb
Copy link
Collaborator

@m-vdb m-vdb commented May 23, 2023

Proposed changes:

  • ...

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@m-vdb m-vdb requested a review from a team as a code owner May 23, 2023 14:52
@m-vdb m-vdb requested review from rasa-aadlv and removed request for a team May 23, 2023 14:52
@m-vdb m-vdb force-pushed the debug-lint-docstrings branch from f328b90 to 635ab35 Compare May 23, 2023 15:01
@m-vdb m-vdb changed the base branch from 3.5.x to main May 23, 2023 15:02
@m-vdb m-vdb force-pushed the debug-lint-docstrings branch from 635ab35 to 45a65a0 Compare May 23, 2023 15:04
@m-vdb m-vdb removed the request for review from rasa-aadlv May 23, 2023 15:04
@m-vdb m-vdb force-pushed the debug-lint-docstrings branch from 45a65a0 to 5f59746 Compare May 23, 2023 15:11
# Compare against `main` if no branch was provided
BRANCH="${1:-main}"

echo "2-here"
# Diff of committed changes (shows only changes introduced by your branch
FILES_WITH_DIFF=`git diff $BRANCH...HEAD --name-only -- rasa | grep -e '\.py$' | xargs echo -n`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to fail

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the offending commit 4aefb5f

@m-vdb m-vdb force-pushed the debug-lint-docstrings branch 3 times, most recently from ae5315a to 8daf3cb Compare May 23, 2023 15:39
@m-vdb m-vdb force-pushed the debug-lint-docstrings branch from 8daf3cb to fe3cdc4 Compare May 23, 2023 15:39
@m-vdb m-vdb requested review from Shmuma and sanchariGr May 23, 2023 15:40
@m-vdb m-vdb changed the title debug: make lint-docstrings Fix make lint-docstrings May 23, 2023
Copy link
Collaborator

@sanchariGr sanchariGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@m-vdb m-vdb merged commit b7a5388 into main May 23, 2023
@m-vdb m-vdb deleted the debug-lint-docstrings branch May 23, 2023 15:47
Copy link
Contributor

@Shmuma Shmuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants