-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case insensitive prompt choices #3052
Case insensitive prompt choices #3052
Conversation
My Markdown formatter automatically changed the URL's in this to the more correct form by wrapping them with '<' and '>', probably shouldn't force my style choices on another project.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3052 +/- ##
==========================================
- Coverage 98.30% 98.28% -0.03%
==========================================
Files 74 74
Lines 8038 8049 +11
==========================================
+ Hits 7902 7911 +9
- Misses 136 138 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
I think this is very useful, and might even be a better default! The only thing I'd say is perhaps Any thoughts @willmcgugan? |
@darrenburns I can quickly rename to |
@darrenburns Done. I renamed the flag and left the default state as |
@darrenburns, is this PR DOA, or will it be looked at in future? It could be a useful addition to the library as it's something I use a lot. I guess I can put it into a separate package if it won't be merged. |
That's up to @willmcgugan |
Thanks for the PR. |
Type of changes
Checklist
Description
Optional flag for
Prompt.ask
allowing case-insensitive responses. Just addcase_sensitive=False
to the command options:Now, it would accept "paul" or "Paul" as valid responses. Defaults to True, which is the usual result.