Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up output #4

Closed
ThinkOpenly opened this issue Mar 4, 2024 · 2 comments
Closed

clean up output #4

ThinkOpenly opened this issue Mar 4, 2024 · 2 comments

Comments

@ThinkOpenly
Copy link
Owner

Lots and lots of debug-level output (noise) is emitted to standard output, along with the JSON (signal).

It would be nice to make this debug output optional, perhaps via a command-line parameter (--debug?) or environment variable.

It would be nice to push the debug output to stderr, so it's easily filtered away by redirection. It appears that changing those non-essential print_endline calls to prerr_endline would go a long way.
@snapdgn
Copy link

snapdgn commented Mar 5, 2024

Hello @ThinkOpenly, I've already begun looking into this, will draft a PR soon.

@snapdgn snapdgn mentioned this issue Mar 5, 2024
Merged
ThinkOpenly pushed a commit that referenced this issue Mar 6, 2024
@snapdgn @ThinkOpenly
[JSON] Emit debug output to stderr
c65ddd8 
In the JSON backend, currently all messages (debug text and JSON data) are emitted to stdout.

Change debug messages to be emitted to stderr by using `prerr_endline` instead of `print_endline`.

Fixes #4.
@ThinkOpenly
Copy link
Owner Author

I thought "Fixes #4" string in the commit message would automatically close this, but no.
Closing... (Will open a new issue for the first part, making the debug output optional.)

rod7760 pushed a commit to rod7760/sail that referenced this issue Mar 29, 2024
@snapdgn @rod7760
[JSON] Emit debug output to stderr
7430278 
In the JSON backend, currently all messages (debug text and JSON data) are emitted to stdout.

Change debug messages to be emitted to stderr by using `prerr_endline` instead of `print_endline`.

Fixes ThinkOpenly#4.
ThinkOpenly pushed a commit that referenced this issue Mar 29, 2024
@snapdgn @ThinkOpenly
[JSON] Emit debug output to stderr
711c7f8 
In the JSON backend, currently all messages (debug text and JSON data) are emitted to stdout.

Change debug messages to be emitted to stderr by using `prerr_endline` instead of `print_endline`.

Fixes #4.
ThinkOpenly pushed a commit that referenced this issue Jun 17, 2024
@snapdgn @ThinkOpenly
[JSON] Emit debug output to stderr
1f383cc 
In the JSON backend, currently all messages (debug text and JSON data) are emitted to stdout.

Change debug messages to be emitted to stderr by using `prerr_endline` instead of `print_endline`.

Fixes #4.
ThinkOpenly pushed a commit that referenced this issue Sep 16, 2024
@snapdgn @ThinkOpenly
[JSON] Emit debug output to stderr
03eb8d5 
In the JSON backend, currently all messages (debug text and JSON data) are emitted to stdout.

Change debug messages to be emitted to stderr by using `prerr_endline` instead of `print_endline`.

Fixes #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThinkOpenly @snapdgn