Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word seperate doesn't works well #3665

Closed
yifeidai opened this issue Apr 8, 2019 · 4 comments
Closed

Word seperate doesn't works well #3665

yifeidai opened this issue Apr 8, 2019 · 4 comments
Labels

Comments

@yifeidai
Copy link

yifeidai commented Apr 8, 2019

Describe the bug
The word-seperate doesn't work well. For example, "a.b.c" is regarded as a word but not three words. In function "hellowWorld(param1, param2)", "hellowWorld(param1" is regarded as a word. It works well a few days ago, but it works wrong now. I don't change any configuration these days. So I can't use keys like "w", "e", "b", "*" properly.
It is now proved that in old vim version: "v1.2.0" it works well.

To Reproduce
Here is my vim config in vscode.

    "vim.disableExtension": false,
    "vim.easymotion": true,
    "vim.sneak": true,
    "vim.incsearch": true,
    "vim.useSystemClipboard": true,
    "vim.useCtrlKeys": true,
    "vim.hlsearch": true,
    "vim.leader": "<space>",
    "vim.handleKeys": {
      "<C-a>": false,
      "<C-f>": false,
      "<C-c>": false,
      "<C-v>": false,
      "<C-h>": false,
      "<C-shift-l>": false,
      "<C-alt-up>": false,
      "<C-alt-down>": false,
      "<C-[>": false,
      "<C-]>": false,
      "<C-w>": false,
      "<C-x>": false,
    },

And here is word seperate config.

    "editor.wordSeparators": "`~!@%^&*()=+[{]}\\|;:'\",.<>-/?",

The vscode's word seperate works well. It means that if I use Ctrl+arrow, "a.b.c" isn't regarded as a whole word.

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.3.0
  • VSCode version: 1.32.3
  • OS: Windows_NT x64 10.0.17134
@ajalab
Copy link
Contributor

ajalab commented Apr 8, 2019

I'm responsible for the recent change in terms of word separation.
I pasted your configuration script to my settings.json and tried it, but actually the problem was not reproduced on my Windows machine.
Would you please show the whole text which produces the problem?

Environment:

  • Extension Version: 1.4.0
  • OS Version: Windows_NT x64 10.0.17134
  • VSCode version: 1.33.0

I also tried it on VsCodeVim version 1.3.0.

@hugoj-goncalves
Copy link

may this be related with this? Working with diacritics is really annoying atm...
issue-2019-04-08 20-04

@ajalab
Copy link
Contributor

ajalab commented Apr 9, 2019

@hugoj-goncalves Thanks for reporting the issue. I didn't notice that... src/common/motion/position.ts currently recognizes a sequence of ASCII characters (except for keywords) and that of diacritics as individual words. They should belong to the same CharKind.

@jpoon
Copy link
Member

jpoon commented Apr 17, 2019

Resolved with #3667 thanks to @ajalab

@jpoon jpoon closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants