Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make surround repeatable with dot #1515

Merged
merged 4 commits into from
Apr 19, 2017
Merged

make surround repeatable with dot #1515

merged 4 commits into from
Apr 19, 2017

Conversation

xconverge
Copy link
Member

A little funky but I don't think its too bad :)

This is to fix #1244

Any suggestions on a better way would be great... @johnfn

@johnfn
Copy link
Member

johnfn commented Apr 16, 2017

I think there should be a better way. Just hold on to this guy: https://github.com/VSCodeVim/Vim/blob/master/src/mode/modeHandler.ts#L105

and then re-execute with him when the user presses .. That should work, right?

@xconverge
Copy link
Member Author

No the problem is getting the operators and movement for the range. It needs to be recalculated based on new position

@xconverge
Copy link
Member Author

Example: ysaw" we need to redo aw

@johnfn
Copy link
Member

johnfn commented Apr 19, 2017

Ah I see. So you'd have to refactor him to change the Range into a Motion or something. Meh, this is fine if you don't want to do that.

@xconverge
Copy link
Member Author

it is SUPER handy to have, that's for sure... I am not sure I know how to do the motion and either way there is some sense of replaying it back, but then atleast the surround object is fully contained

@xconverge xconverge merged commit 737ef47 into VSCodeVim:master Apr 19, 2017
@xconverge xconverge deleted the make-surround-repeatable branch April 19, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

surround should be repeatable with .
2 participants