Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cobbweb/more readme fixes #1656

Merged
merged 2 commits into from
May 22, 2017

Conversation

cobbweb
Copy link
Contributor

@cobbweb cobbweb commented May 5, 2017

Can be previewed here.

Added a silly badge just for you @johnfn (let me know when/if to remove this)

@cobbweb cobbweb force-pushed the cobbweb/more-readme-fixes branch from e640531 to adc5a2a Compare May 6, 2017 02:47
@jpoon
Copy link
Member

jpoon commented May 6, 2017

I may have missed the joke. What's this potato badge?

README.md Outdated
<p align="center"><strong>Vim emulation for Visual Studio Code.</strong></p>
<p align="center"><a href="http://aka.ms/vscodevim"><img src="http://vsmarketplacebadge.apphb.com/version/vscodevim.vim.svg" alt="Version"></a><a href="https://travis-ci.org/VSCodeVim/Vim"><img src="https://travis-ci.org/VSCodeVim/Vim.svg?branch=master" alt="Build Status"></a><a href="https://vscodevim-slackin.azurewebsites.net"><img src="https://vscodevim-slackin.azurewebsites.net/badge.svg" alt="Slack Status"></a></p>
<p align="center"><a href="http://aka.ms/vscodevim"><img src="http://vsmarketplacebadge.apphb.com/version/vscodevim.vim.svg" alt="Version"></a> <a href="https://github.com/VSCodeVim/Vim/pull/1643"><img src="https://img.shields.io/badge/potato-procrastinating-208ecd.svg" alt="Build Status"></a> <a href="https://vscodevim-slackin.azurewebsites.net"><img src="https://vscodevim-slackin.azurewebsites.net/badge.svg" alt="Slack Status"></a></p>
Copy link
Member

@jpoon jpoon May 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a link to "https://github.co m//pull/1643"

This should point to the main repo and not to the PR.

@xconverge
Copy link
Member

Haha yea we can remove the potato badge

@jpoon jpoon self-requested a review May 9, 2017 05:37
jpoon
jpoon previously requested changes May 9, 2017
Copy link
Member

@jpoon jpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. update the link
  2. remove the potato badge

@johnfn
Copy link
Member

johnfn commented May 9, 2017

Lol. I was talking with cobbwebb and we were talking about how every repo has a bunch of badges that don't really mean anything. We thought it would be funny to, on the end of our badge list, have a badge that was totally pointless.

It would also be a great indication of VSCodeVim "culture". 😁 And completely harmless fun!

@cobbweb
Copy link
Contributor Author

cobbweb commented May 11, 2017

Sorry, off grid traveling at the moment... Won't get to fix this up for a week or so. Just want to confirm the build status badge should still be removed?

@Chillee
Copy link
Member

Chillee commented May 11, 2017

@cobbweb Nah I think we should keep the build status page. @jpoon put in some work to fix all the failing tests, so a failing travis build should actually mean something now.

Andrew Cobby added 2 commits May 22, 2017 10:47
I accidentally broke this in VSCodeVim#1643, the change to the src URL wasn't intentional.
@cobbweb cobbweb force-pushed the cobbweb/more-readme-fixes branch from dc18a81 to 11a43cc Compare May 22, 2017 00:50
@cobbweb
Copy link
Contributor Author

cobbweb commented May 22, 2017

Sorry for delay. Branch fixed up: left build badge as-is, fixed logo src, fixed another heading bug

@xconverge xconverge dismissed jpoon’s stale review May 22, 2017 21:17

was addressed

@xconverge xconverge merged commit 1e97bc7 into VSCodeVim:master May 22, 2017
@cobbweb cobbweb deleted the cobbweb/more-readme-fixes branch May 22, 2017 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants