-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cobbweb/more readme fixes #1656
Cobbweb/more readme fixes #1656
Conversation
e640531
to
adc5a2a
Compare
I may have missed the joke. What's this potato badge? |
README.md
Outdated
<p align="center"><strong>Vim emulation for Visual Studio Code.</strong></p> | ||
<p align="center"><a href="http://aka.ms/vscodevim"><img src="http://vsmarketplacebadge.apphb.com/version/vscodevim.vim.svg" alt="Version"></a><a href="https://travis-ci.org/VSCodeVim/Vim"><img src="https://travis-ci.org/VSCodeVim/Vim.svg?branch=master" alt="Build Status"></a><a href="https://vscodevim-slackin.azurewebsites.net"><img src="https://vscodevim-slackin.azurewebsites.net/badge.svg" alt="Slack Status"></a></p> | ||
<p align="center"><a href="http://aka.ms/vscodevim"><img src="http://vsmarketplacebadge.apphb.com/version/vscodevim.vim.svg" alt="Version"></a> <a href="https://github.com/VSCodeVim/Vim/pull/1643"><img src="https://img.shields.io/badge/potato-procrastinating-208ecd.svg" alt="Build Status"></a> <a href="https://vscodevim-slackin.azurewebsites.net"><img src="https://vscodevim-slackin.azurewebsites.net/badge.svg" alt="Slack Status"></a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a link to "https://github.co m//pull/1643"
This should point to the main repo and not to the PR.
Haha yea we can remove the potato badge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- update the link
- remove the potato badge
Lol. I was talking with cobbwebb and we were talking about how every repo has a bunch of badges that don't really mean anything. We thought it would be funny to, on the end of our badge list, have a badge that was totally pointless. It would also be a great indication of VSCodeVim "culture". 😁 And completely harmless fun! |
Sorry, off grid traveling at the moment... Won't get to fix this up for a week or so. Just want to confirm the build status badge should still be removed? |
I accidentally broke this in VSCodeVim#1643, the change to the src URL wasn't intentional.
dc18a81
to
11a43cc
Compare
Sorry for delay. Branch fixed up: left build badge as-is, fixed logo src, fixed another heading bug |
Can be previewed here.
Added a silly badge just for you @johnfn (let me know when/if to remove this)