Add %. #319
Merged
Add %. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh great... now Travis is telling me the tests pass when they fail. Apparently the only way to get them to pass is to cause them to fail so bad they don't even run. 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do a fairly basic implementation that only tracks the state of the type character you're over and its pair (e.g. "[" and "]"). This is similar to what Vim does.
It can't handle strings very well - something like "|( ')' )" where | is the cursor will cause it to go to the ) in the quotes, even though it should skip over it.
PRs welcomed! I have this case at low priority because I believe it's a lot of effort for very little gain.
Ideally though, VSC implements microsoft/vscode#7177.